Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the DOM-Parsing IDL file #9752

Merged

Conversation

5 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 20:43:24
Finished: 2018-03-07 20:53:31

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-DOM-Parsing branch from f293296 to af2a32a Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

Seems like there is no existing test under https://github.com/w3c/web-platform-tests/tree/master/domparsing. Can you add one?

(Also indentation needs updating.)

Luke Bjerring and others added some commits Mar 2, 2018

@foolip foolip force-pushed the lukebjerring:idl-file-updates-DOM-Parsing branch from af2a32a to 1fbb365 Apr 6, 2018

@wpt-pr-bot wpt-pr-bot requested review from ChrisParis and jdm Apr 6, 2018

@foolip

foolip approved these changes Apr 6, 2018

Copy link
Contributor

foolip left a comment

LGTM % serializeAsCDATA

};

partial interface Text {
attribute boolean serializeAsCDATA;

This comment has been minimized.

Copy link
@foolip

foolip Apr 6, 2018

Contributor

I've added a test, and a failure pointed to something odd here. serializeAsCDATA isn't actually in the spec, it's commented out:
https://github.com/w3c/DOM-Parsing/blob/ba763b4d81a5a1fb5ec37deebf93659d853850e7/index.html#L608

@mdittmer any idea why that might be happening? Isn't a real HTML parser being used?

This comment has been minimized.

Copy link
@mdittmer

mdittmer Apr 6, 2018

Contributor

Nope.

@domenic domenic removed their request for review Apr 20, 2018

@mdittmer

This comment has been minimized.

Copy link
Contributor

mdittmer commented May 17, 2018

@lukebjerring is this still relevant or abandoned?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented May 17, 2018

Abandoned.

@lukebjerring lukebjerring reopened this May 22, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented May 22, 2018

Un-abandoned.

};

partial interface Text {
attribute boolean serializeAsCDATA;

This comment has been minimized.

Copy link
@foolip

foolip May 23, 2018

Contributor

This bit still needs to be removed. Manually perhaps? Or by switching to Reffy as data source?

@foolip

foolip approved these changes May 28, 2018

@foolip foolip merged commit 0f22262 into web-platform-tests:master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.