Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the FileAPI IDL file #9753

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 2, 2018

Oh, so some spec have already adopted the style I was proposing in #9026. This is one, and this IDL file exists elsewhere:
https://github.com/w3c/web-platform-tests/blob/master/FileAPI/idlharness.idl

There are some differences that should be reconciled. I have a commit for it, but it seems like I can't push commits to the PR. (There's a setting to allow that even for forks, but it probably wasn't set for this PR.)

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-08 17:04:34
Finished: 2018-03-08 17:13:26

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-FileAPI branch from 9ecf6e2 to bdcca00 Mar 7, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-FileAPI branch from bdcca00 to 93cb2db Mar 8, 2018

@foolip

foolip approved these changes Apr 6, 2018

Copy link
Contributor

foolip left a comment

Confirmed that the including tests still work (no failures at all)

@foolip foolip merged commit 0cddb68 into web-platform-tests:master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.