Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the InputDeviceCapabilities IDL file with test #9755

Conversation

7 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 21:14:08
Finished: 2018-03-07 21:24:36

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-InputDeviceCapabilities branch from 75bafef to b51b022 Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

This is odd. I found http://wicg.github.io/InputDeviceCapabilities/tests/ outside of wpt. @RByers, are those good tests that should be moved?

@domenic domenic removed their request for review Apr 20, 2018

@RByers

This comment has been minimized.

Copy link
Contributor

RByers commented May 22, 2018

This is odd. I found http://wicg.github.io/InputDeviceCapabilities/tests/ outside of wpt. @RByers, are those good tests that should be moved?

Sorry I missed this. Yes, I think so. They were all manual tests, so would ideally be updated to use testdriver (or where not yet possible, named -manual). I think these dated back to a time where we felt WPT wasn't appropriate for "incubation" features with support only in one browser. Sadly still the case AFAIK for InputDeviceCapabilities....

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented May 23, 2018

@RByers is there someone who now works on those features who might be able to move those tests? Especially ones for bits we've already shipped would be valuable, and if they reveal missing testdriver bits I'm sure @kereliuk would like to know.

@foolip foolip changed the title Update the InputDeviceCapabilities IDL file Add the InputDeviceCapabilities IDL file with test Jun 8, 2018

@foolip foolip requested review from RByers and removed request for jensl and yuki3 Jun 8, 2018

@RByers

This comment has been minimized.

Copy link
Contributor

RByers commented Jun 8, 2018

@RByers is there someone who now works on those features who might be able to move those tests? Especially ones for bits we've already shipped would be valuable, and if they reveal missing testdriver bits I'm sure @kereliuk would like to know.

Sorry I mised this. @SummerLW worked on them in the past, and @NavidZ is the right expert for all input test automation.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Jun 8, 2018

@foolip foolip requested review from NavidZ and removed request for RByers Jun 8, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 8, 2018

@SummerLW can you take a look? Are you OK with being in the OWNERS so that you're added on new reviews in this directory?

@NavidZ

This comment has been minimized.

Copy link
Contributor

NavidZ commented Jun 8, 2018

We should be able to do that. As soon as @kereliuk lands his CL for pointer actions in wpt we should be able to start updating those manual tests and add the automation instructions.

@SummerLW

This comment has been minimized.

Copy link
Contributor

SummerLW commented Jun 8, 2018

@NavidZ

NavidZ approved these changes Jun 8, 2018

Copy link
Contributor

NavidZ left a comment

This particular API has been in Chrome for quite a while and not been implemented by other browsers. I'll try to come up with a plan say next quarter to get them more engaged hopefully.


dictionary InputDeviceCapabilitiesInit {
boolean firesTouchEvents = false;
boolean pointerMovementScrolls = false;

This comment has been minimized.

Copy link
@NavidZ

NavidZ Jun 8, 2018

Contributor

Even Chrome hasn't implemented this bit :). But I guess from the test point of view this would be alright.

This comment has been minimized.

Copy link
@foolip

foolip Jun 8, 2018

Contributor

Yep, I noticed it was failing. But correctly so, should be removed from spec if it stays failing in all browsers forever, so having the test can help surface that later :)

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 8, 2018

Thanks @SummerLW @NavidZ, I'll go ahead and merge this.

@foolip foolip merged commit 3bc4498 into web-platform-tests:master Jun 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-InputDeviceCapabilities branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.