Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ResizeObserver IDL file #9756

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 21:23:12
Finished: 2018-03-07 21:31:51

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-ResizeObserver branch from 1c019c7 to 1a5c86b Mar 7, 2018

void disconnect();
};

callback ResizeObserverCallback = void (sequence<ResizeObserverEntry> entries, ResizeObserver observer)

This comment has been minimized.

Copy link
@foolip

foolip Apr 6, 2018

Contributor

Sent WICG/ResizeObserver#56 to fix a missing semicolon here, will add it manually too.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 6, 2018

Author Contributor

Added manually for now.


[Constructor(Element target)
]
interface ResizeObservation {

This comment has been minimized.

Copy link
@foolip

foolip Apr 6, 2018

Contributor

There's a problem here, found existing bug: WICG/ResizeObserver#46

@foolip foolip force-pushed the lukebjerring:idl-file-updates-ResizeObserver branch from 1a5c86b to 761ed9e Apr 6, 2018

@wpt-pr-bot wpt-pr-bot requested review from atotic and dholbert Apr 6, 2018

@foolip

foolip approved these changes Apr 6, 2018

Copy link
Contributor

foolip left a comment

LGTM % ResizeObservation. Maybe manually exclude it, or hold off? Either WFM.

Luke Bjerring and others added some commits Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-ResizeObserver branch from 761ed9e to 0fc3724 Apr 6, 2018

@domenic domenic removed their request for review Apr 20, 2018

lukebjerring added some commits May 23, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 6, 2018

As discussed offline, the incorrect source IDL shouldn't be tweaked as part of a semi-automated import flow, because the edge-case handling or manual work will keep repeating. We should just let the tests fail, and have bad test results as the motivation to correct the source.

@foolip
Copy link
Contributor

foolip left a comment

Oops, needs a test to use the IDL

@foolip

foolip approved these changes Jun 8, 2018

Copy link
Contributor

foolip left a comment

Thanks!

@foolip foolip merged commit 7684fe3 into web-platform-tests:master Jun 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.