Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the aom IDL file #9759

Closed

Conversation

6 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 21:49:10
Finished: 2018-03-07 21:59:23

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-aom branch from c641943 to f53ca26 Mar 7, 2018

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 21, 2018

@wpt-pr-bot wpt-pr-bot added the aom label Jun 21, 2018

@lukebjerring lukebjerring requested review from foolip and removed request for jensl and yuki3 Jun 21, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-aom branch from 8ebe9e6 to 6f9b79c Jun 21, 2018

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jun 21, 2018

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

lukebjerring and others added some commits Jun 27, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jul 16, 2018

IDL and test looks good, just needs reviewers in META.yml. https://wicg.github.io/aom/spec/ has these editors:

I have sent all four of you invites to the web-platform-tests org, which you can view/accept at https://github.com/web-platform-tests. If one or more of you could volunteer to get reviews for this directory, it would be much appreciated!

I've updated META.yml in this PR to list all of you, but will await confirmation and remove anyone who doesn't reply.

@foolip

foolip approved these changes Jul 16, 2018

Copy link
Contributor

foolip left a comment

LGTM, but need to await suggested reviewers.

@alice

This comment has been minimized.

Copy link
Contributor

alice commented Jul 17, 2018

Note that the version of the spec which includes these IDL properties has been deprecated: https://wicg.github.io/aom/spec/phase1.html

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jul 17, 2018

Oh, interesting. These IDL files are from reffy, so I filed tidoust/reffy-reports#10. This PR shouldn't be merged then.

@foolip foolip closed this Jul 17, 2018

@alice

This comment has been minimized.

Copy link
Contributor

alice commented Jul 18, 2018

Can you help me understand how things get picked up by reffy, so I can make sure it stays up to date with AOM?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jul 18, 2018

I'm afraid I don't know the details myself, hoping to find out in tidoust/reffy-reports#10. I'm hopeful that it can be made to just work, so that if something like this happens again, the idl file is simply deleted.

@tidoust

This comment has been minimized.

Copy link
Contributor

tidoust commented Jul 19, 2018

I tried to explain why we ended up in that situation in tidoust/reffy-reports#10 and why it might happen again. I created tidoust/reffy-reports#12 to track the creation of an alert system so that we be notified in the future when an IDL file likely needs to be deleted.

@lukebjerring lukebjerring moved this from In progress to Done in Auto-import IDL files Jul 26, 2018

@lukebjerring lukebjerring moved this from Done to In progress in Auto-import IDL files Jul 26, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jul 26, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jul 26, 2018

@lukebjerring lukebjerring reopened this Jul 26, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jul 26, 2018

Whoops, moving columns affects PR state.

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-aom branch Jul 26, 2018

@lukebjerring lukebjerring moved this from In progress to Done in Auto-import IDL files Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.