Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the budget-api IDL file #9763

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 22:28:18
Finished: 2018-03-07 22:36:56

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-budget-api branch from 7e366b2 to 8cf67b9 Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

Seems like there aren't any existing tests for this spec either. Can you create one?

Luke Bjerring and others added some commits Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-budget-api branch from 8cf67b9 to 3266950 Apr 5, 2018

@lukebjerring lukebjerring requested a review from foolip Apr 5, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Apr 5, 2018

Note that the added test simply fails, due to duplicate Exposed attributes on the interfaces.
Filed #10338 to cover that.

@foolip

foolip approved these changes Apr 5, 2018

@lukebjerring lukebjerring merged commit 67c2a87 into web-platform-tests:master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-budget-api branch Apr 6, 2018

foolip added a commit that referenced this pull request Jun 11, 2018

Clean up budget-api idl test (#11445)
Follow up for #9763 now that #10338 is resolved and we have #10381 too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.