Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cors-rfc1918 IDL file #9767

Merged

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-cors-rfc1918 branch from 434a93d to 362269d Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 23:06:21
Finished: 2018-03-07 23:16:10

View more information about this build on:

@domenic domenic removed their request for review Apr 20, 2018

@wpt-pr-bot wpt-pr-bot added the fetch label Jun 18, 2018

@wpt-pr-bot wpt-pr-bot requested review from annevk, hillbrad, jdm, odinho and zqzhang Jun 18, 2018

@lukebjerring lukebjerring requested a review from foolip Jun 18, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 18, 2018

@foolip - Added a test. PTAL.

@annevk
Copy link
Member

annevk left a comment

I'm not sure this should be inside the cors/ directory. fetch is probably more suitable if we don't want this as its own top-level thing. @mikewest?

@mikewest

This comment has been minimized.

Copy link
Contributor

mikewest commented Jun 18, 2018

Putting them under /fetch/cors-rfc1918/ seems right to me. I'd also name them as .tentative, since I don't think we're anywhere near consensus that it's the right thing to do. :)

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@wpt-pr-bot wpt-pr-bot requested a review from domfarolino Jun 18, 2018

@wpt-pr-bot wpt-pr-bot requested review from mnot, youennf and yutakahirano Jun 18, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 18, 2018

Alrighty, moved as requested.

@annevk

annevk approved these changes Jun 19, 2018

@annevk annevk merged commit 0007ac4 into web-platform-tests:master Jun 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring moved this from In progress to Done in Auto-import IDL files Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.