Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idlharness test for CSS Device Adaptation #9770

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Uses the IDL file from #12911.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 23:24:54
Finished: 2018-03-07 23:33:01

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-device-adapt branch from 03ee78f to 966871b Mar 7, 2018

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 28, 2018

@lukebjerring lukebjerring removed request for jensl and yuki3 Jun 28, 2018

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jun 28, 2018

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 28, 2018

@ChumpChief - I don't seem to be able to add you as a reviewer. @foolip do you know why that is?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jul 16, 2018

That's because @ChumpChief isn't a member of the web-platform-tests org. I've sent an invite which can be accepted at https://github.com/web-platform-tests.

spec: https://drafts.csswg.org/css-device-adapt/
suggested_reviewers:
- ChumpChief
- frivoal

This comment has been minimized.

Copy link
@foolip

foolip Aug 4, 2018

Contributor

@frivoal I see you are listed as editor of CSS Device Adaptation, would you like to get reviews for this directory?

@foolip foolip force-pushed the lukebjerring:idl-file-updates-css-device-adapt branch from 3e97ddc to 95e2af4 Aug 4, 2018

@foolip foolip requested a review from frivoal Aug 4, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-device-adapt branch from 931918f to b6352d2 Sep 10, 2018

@foolip foolip changed the title Update the css-device-adapt IDL file Add idlharness test for CSS Device Adaptation Sep 11, 2018

@foolip

foolip approved these changes Sep 11, 2018

Show resolved Hide resolved css/css-device-adapt/META.yml
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Sep 11, 2018

@ChumpChief has confirmed over email he's OK with this, so I'll change META.yml back.

@foolip foolip merged commit 93fe0ed into web-platform-tests:master Sep 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Sep 11, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-css-device-adapt branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.