Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idlharness test for CSS Layout API #9772

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Builds on #12912.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-07 23:34:01
Finished: 2018-03-07 23:49:39

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-layout-api branch from 04aef65 to 7ddda8b Mar 7, 2018

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@wpt-pr-bot wpt-pr-bot requested review from bfgeek and tabatkins Jun 21, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 21, 2018

@lukebjerring lukebjerring requested review from foolip and removed request for jensl and yuki3 Jun 21, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 21, 2018

Note that test is currently broken by use of sequence instead of iterable (which I replaced locally to work out all the correct deps).

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 21, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jul 16, 2018

I've updated the test to use idl_test, but it's still entirely broken by the use of sequence<T>. @bfgeek @tabatkins, can you take a look at w3c/css-houdini-drafts#758 to unblock this PR? Thanks!

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Aug 4, 2018

Sent a PR for it: w3c/css-houdini-drafts#786

@foolip
Copy link
Contributor

foolip left a comment

Because of [Exposed=LayoutWorklet] this test isn't going to do much. We'll presumably have to teach idlharness.js about LayoutWorklet, and create a LayoutWorklet here for the tests. Didn't notice the same problem in #9773, but added a note to https://github.com/web-platform-tests/wpt/projects/1 about this.

@foolip foolip changed the title Update the css-layout-api IDL file Add idlharness test for CSS Layout API Sep 11, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-css-layout-api branch Oct 5, 2018

Auto-import IDL files automation moved this from In progress to Done Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.