Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the css-paint-api IDL file #9773

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 7, 2018

No existing tests under css/css-paint-api/, so we'll need to add one.

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-paint-api branch from 3b37f2d to 2b5a2d6 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-07 23:53:37
Finished: 2018-03-08 00:04:12

View more information about this build on:

@domenic domenic removed their request for review Apr 20, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented May 23, 2018

No existing tests under css/css-paint-api/, so we'll need to add one.

Still true.

lukebjerring added some commits Jun 5, 2018

@wpt-pr-bot wpt-pr-bot requested review from bfgeek, grorg and shans Jun 6, 2018

lukebjerring added a commit to lukebjerring/css-houdini-drafts that referenced this pull request Jun 6, 2018

Fix mixin keyword in IDL
While adding a test in web-platform-tests/wpt#9773 it highlighted the incorrect IDL. `CanvasState` etc are `interface mixin`s, not interfaces, so are to be `includes` not `implements`.

lukebjerring added a commit to lukebjerring/css-houdini-drafts that referenced this pull request Jun 6, 2018

Fix mixin keyword in IDL
While adding a test in web-platform-tests/wpt#9773 it highlighted the incorrect IDL. `CanvasState` etc are `interface mixin`s, not interfaces, so are to be `includes` not `implements`.
@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 6, 2018

Test added, which currently fails hard (see w3c/css-houdini-drafts#765).

bfgeek added a commit to w3c/css-houdini-drafts that referenced this pull request Jun 6, 2018

Fix mixin keyword in IDL (#765)
While adding a test in web-platform-tests/wpt#9773 it highlighted the incorrect IDL. `CanvasState` etc are `interface mixin`s, not interfaces, so are to be `includes` not `implements`.
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 8, 2018

lukebjerring and others added some commits Jun 11, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 12, 2018

Updated! Only failure in chrome is

SS interface: attribute paintWorklet
assert_true: The prototype object must have a property "paintWorklet" expected true got false

@foolip

foolip approved these changes Jun 12, 2018

@foolip foolip merged commit 2b9df3e into web-platform-tests:master Jun 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-css-paint-api branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.