Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the css-properties-values-api IDL file #9774

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-properties-values-api branch from cb087b1 to 1182b47 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build ERRORED

Started: 2018-03-08 00:11:30
Finished: 2018-03-08 00:24:50

Failing Jobs

  • firefox:nightly
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-properties-values-api branch from 1182b47 to 30997d1 Mar 7, 2018

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to idlharness.js blockers/issues in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from idlharness.js blockers/issues to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 27, 2018

@wpt-pr-bot wpt-pr-bot requested review from astearns and tabatkins Jun 27, 2018

@lukebjerring lukebjerring requested review from foolip and removed request for jensl and yuki3 Jun 27, 2018

dictionary PropertyDescriptor {
required DOMString name;
DOMString syntax = "*";
boolean inherits = false;

This comment has been minimized.

Copy link
@foolip

foolip Jul 16, 2018

Contributor

@lukebjerring this is out of sync with the spec, can you update this PR?

Luke Bjerring added some commits Jul 26, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-css-properties-values-api branch from 9dac8c2 to 6dd530c Jul 26, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jul 26, 2018

Updated. PTAL.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jul 26, 2018

Note that we'll have an unimportant failure for the partial CSS namespace until #11819 lands.

@foolip

foolip approved these changes Jul 27, 2018

@foolip foolip merged commit a71bbf1 into web-platform-tests:master Jul 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jul 27, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-css-properties-values-api branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.