Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cssom IDL file #9776

Merged

Conversation

6 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-cssom branch from 919d86b to ee08206 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-08 22:58:13
Finished: 2018-03-08 23:10:39

This report has been truncated because the number of unstable tests exceeds GitHub.com's character limit for comments (65536 characters).

Failing Jobs

  • MicrosoftEdge:16.16299
  • safari:11.0

Unstable Browsers

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Luke Bjerring
@@ -123,6 +128,18 @@ interface CSSStyleDeclaration {
[CEReactions] attribute [TreatNullAs=EmptyString] CSSOMString cssFloat;
};

partial interface CSSStyleDeclaration {
[CEReactions] attribute [TreatNullAs=EmptyString] CSSOMString _camel_cased_attribute;

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 13, 2018

Contributor

This is wrong, given this is actually some magic variable thing.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 15, 2018

Author Contributor

@foolip - These aren't really part of the spec; do we have (or, need) a mechanism for excluding example/descriptive snippets of IDL from being scraped?

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 15, 2018

Contributor

I think this might be a CSSOM-only oddity? Most other places the web platform does such things we rely on named getters, hence it might not be necessary to have a general solution to this problem?

This comment has been minimized.

Copy link
@foolip

foolip Mar 16, 2018

Contributor

IDL in examples is already excluded, but this is a macro of sorts. I guess what we should do is to generate the IDL that it expands to just like how implementations should and Gecko in fact does.

But just excluding this snippet with some string matching hack should be a good enough start.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 28, 2018

Author Contributor

@mdittmer - I'll delegate to the scraper tool to ignore these chunks.

This comment has been minimized.

Copy link
@mdittmer

mdittmer Mar 29, 2018

Contributor

@gsnedders, if this isn't really IDL, would it be possible to mark it with the note, or even example CSS class?

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 29, 2018

Author Contributor
};

partial interface CSSStyleDeclaration {
[CEReactions] attribute [TreatNullAs=EmptyString] CSSOMString _webkit_cased_attribute;

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 13, 2018

Contributor

This is wrong, given this is actually some magic variable thing.

};

partial interface CSSStyleDeclaration {
[CEReactions] attribute [TreatNullAs=EmptyString] CSSOMString _dashed_attribute;

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 13, 2018

Contributor

This is wrong, given this is actually some magic variable thing.

lukebjerring added a commit to lukebjerring/csswg-drafts that referenced this pull request Mar 29, 2018

Flag non-spec IDL with class `note`
Fixes w3c#2486 which blocks web-platform-tests/wpt#9776

The snippets are for showing what form the generated output will take, not for should-be-tested IDL.
@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Apr 6, 2018

@gsnedders can I get an LGTM

@foolip

foolip approved these changes Apr 6, 2018

Issues addressed

@foolip foolip merged commit d6a82fd into web-platform-tests:master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.