Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cssom-view IDL file #9777

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-cssom-view branch from 66699ad to 5039540 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-08 00:35:01
Finished: 2018-03-08 00:48:49

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/css/cssom-view/interfaces.html   OK: 9
ERROR: 1
  Test driver FAIL: 9
promise_test: Unhandled rejection with value: "Partial interface MouseEvent with no original interface"

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/css/cssom-view/interfaces.html   TIMEOUT: 1
OK: 3
ERROR: 6
  Test driver FAIL: 3
promise_test: Unhandled rejection with value: "Partial interface MouseEvent with no original interface"

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 28, 2018

@wpt-pr-bot wpt-pr-bot requested review from AutomatedTester and plinss Jun 28, 2018

@lukebjerring lukebjerring removed request for jensl and yuki3 Jun 28, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jul 28, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jul 28, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-cssom-view branch from b3dfa49 to 777ae90 Jul 28, 2018

lukebjerring and others added some commits Jul 31, 2018

Luke Bjerring

@lukebjerring lukebjerring requested a review from foolip Jul 31, 2018

@wpt-pr-bot wpt-pr-bot requested a review from frivoal Jul 31, 2018

@foolip

foolip approved these changes Jul 31, 2018

Copy link
Contributor

foolip left a comment

@lukebjerring, your changes LGTM, I also added a test for css-pseudo, please review check that before merging.

@lukebjerring lukebjerring merged commit 54401a0 into web-platform-tests:master Jul 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jul 31, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-cssom-view branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.