Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the orientation-event IDL file #9778

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-deviceorientation branch from 9cbb855 to 5c29b99 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-08 00:57:53
Finished: 2018-03-08 01:09:14

View more information about this build on:

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 21, 2018

@wpt-pr-bot wpt-pr-bot requested a review from reillyeon Jun 21, 2018

@lukebjerring lukebjerring changed the title Update the deviceorientation IDL file Update the orientation-event IDL file Jun 21, 2018

@lukebjerring lukebjerring requested review from foolip and removed request for jensl and yuki3 Jun 21, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 21, 2018

@foolip - stranglely, the original test idlharness.html had 2 failures, as seen here:
http://w3c-test.org/orientation-event/idlharness.html

However, after migrating to idlharness.window.js and add_dependency_idls, those 2 tests now pass..
I'm confused why the prototype object would suddenly have those attributes. The order of execution has changed too. ¯\(ツ)

idl_array.add_idls(idl);
idl_array.add_dependency_idls(html);
idl_array.add_dependency_idls(dom);
idl_array.add_dependency_idls(uievents);

This comment has been minimized.

Copy link
@reillyeon

reillyeon Jun 21, 2018

Contributor

Is this dependency necessary?

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 21, 2018

Author Contributor

I thought it was earlier, but seems happy without it now - removed.

@lukebjerring lukebjerring merged commit 5ec42d4 into web-platform-tests:master Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 21, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 26, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-deviceorientation branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.