Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the encrypted-media IDL file #9781

Conversation

6 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-encrypted-media branch from c84cd33 to dc994bd Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-08 17:43:24
Finished: 2018-03-08 17:56:02

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-encrypted-media branch from dc994bd to 38116f0 Mar 8, 2018

@domenic domenic removed their request for review Apr 20, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@wpt-pr-bot wpt-pr-bot requested a review from ddorwin Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring requested a review from foolip Jun 18, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 18, 2018

So, while I can't vouch for the changes in the IDL, the tests are passing 107/107, so... seems legit. @foolip - who'd be best to eyeball the update?

@ddorwin

This comment has been minimized.

Copy link
Contributor

ddorwin commented Jun 18, 2018

@foolip

foolip approved these changes Jun 18, 2018

Copy link
Contributor

foolip left a comment

Looks good to my eyeballs.

@jrummell-chromium

This comment has been minimized.

Copy link
Contributor

jrummell-chromium commented Jun 20, 2018

The only real difference I see is the old IDL had MediaKeySessionType::persistent-usage-record, which is no longer in the spec. So no problems with the change.

However, there are several current tests that use "persistent-usage-record". It looks like that is coming back into the next version of the spec, so the tests might as well remain.

@lukebjerring lukebjerring merged commit 4321fff into web-platform-tests:master Jun 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 20, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 26, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-encrypted-media branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.