Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the entries-api IDL file #9782

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-entries-api branch from f679b47 to 0897a60 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build ERRORED

Started: 2018-03-08 23:13:55
Finished: 2018-03-08 23:19:32

Failing Jobs

  • manifest_upload
  • lint
  • update_built
  • firefox:nightly
  • tools_unittest in py27
  • tools_unittest in py36
  • tools_unittest in pypy
  • resources_unittest in py27
  • wpt_integration in py27,py27-flake8
  • wptrunner_infrastructure
  • build_css
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-entries-api branch from 0897a60 to b185464 Mar 8, 2018

Luke Bjerring
@foolip

foolip approved these changes Mar 8, 2018


interface FileSystemFileEntry : FileSystemEntry {
void file(FileCallback successCallback,
optional ErrorCallback errorCallback);
};
callback interface FileCallback {
void handleEvent(File file);

This comment has been minimized.

Copy link
@foolip

foolip Mar 8, 2018

Contributor

Yeah, this old pattern is just because of an oddity in Blink/WebKit bindings generations and should never have made it into any spec, glad it's gone!

(The resulting generated bindings didn't allow you to use { handleEvent: function(file) { ... } } as the callback, so it was just a lie.)

@foolip foolip merged commit 9817f7f into web-platform-tests:master Mar 8, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-entries-api branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.