Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the feature-policy IDL file #9783

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@foolip
Copy link
Contributor

foolip left a comment

Needs a test to use it, and I should go home.

@@ -0,0 +1,3 @@
partial interface HTMLIFrameElement {

This comment has been minimized.

Copy link
@foolip

foolip Mar 7, 2018

Contributor

Wow, this is the least amount of IDL I've seen in any spec:
https://wicg.github.io/feature-policy/#integrations

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-feature-policy branch from f48bc94 to c5e6f27 Mar 7, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-14 17:44:54
Finished: 2018-03-14 17:51:34

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-feature-policy branch from c5e6f27 to 7b0a040 Mar 14, 2018

@wpt-pr-bot wpt-pr-bot requested a review from clelland Mar 14, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 14, 2018

Added a test, PTAL.

@foolip

foolip approved these changes Mar 14, 2018

Copy link
Contributor

foolip left a comment

LGTM % the extra bits


"use strict";

if (self.importScripts) {

This comment has been minimized.

Copy link
@foolip

foolip Mar 14, 2018

Contributor

These bits ought to not be needed, sent #10033 to confirm.

Luke Bjerring

@lukebjerring lukebjerring merged commit e4b9ecc into web-platform-tests:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-feature-policy branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.