Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the geometry IDL file #9787

Merged

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-geometry branch from 525064b to 7056328 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 2, 2018

Build PASSED

Started: 2018-03-23 13:52:21
Finished: 2018-03-23 14:00:45

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-geometry branch from 7056328 to 321012a Mar 7, 2018

@foolip

foolip approved these changes Mar 8, 2018

Copy link
Contributor

foolip left a comment

Yay for removing [NoInterfaceObject] \o/

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 9, 2018

These changes are good, but looking at https://pulls.web-platform-tests.org/build/25659 I realize we have a problem: we're not running any tests when updating the IDL files even though locally wpt tests-affected does list css/cssom-view/interfaces.html. It doesn't list css/geometry/interfaces.html because an indirection via css/geometry/support/interfaces.js.

So, um... filed web-platform-tests/pulls.web-platform-tests.org#61 for the fact that the results for Firefox weren't saved even though they did run. Tested https://web-platform.test:8443/css/geometry/interfaces.html locally, and we get new harness error:

3 duplicate test names: "Test default toJSON operation of DOMPointReadOnly", "Test default toJSON operation of DOMRectReadOnly", "Test default toJSON operation of DOMMatrixReadOnly"

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 9, 2018

Sigh, I'm pretty sure this is just something that idlharness.js doesn't get right, and we need to fix before merging this. Not filing an issue for now.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 14, 2018

7ab9a09 handles one of the duplicate test name causes, and
#10029 handles the other, though needs review.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-geometry branch from 7ab9a09 to 3982bf8 Mar 23, 2018

@lukebjerring lukebjerring merged commit a149250 into web-platform-tests:master Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-geometry branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.