Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediacapture-main IDL file #9794

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 3, 2018

Build PASSED

Started: 2018-03-08 03:07:42
Finished: 2018-03-08 03:14:59

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-mediacapture-main branch from 2fa3b6a to 6d5ed40 Mar 7, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 18, 2018

@foolip - Note that the test for MediaDevices-IDL-all.html is currently failing until https://chromium-review.googlesource.com/c/chromium/src/+/1104707 lands:

promise_test: Unhandled rejection with value: "Navigator implements NavigatorUserMedia, but Navigator is undefined."

chromium-wpt-export-bot pushed a commit that referenced this pull request Jun 18, 2018

Luke Bjerring Chrome-bot
[idlharness.js] Add main interface as dep for implements
Case was revealed by #9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

chromium-wpt-export-bot pushed a commit that referenced this pull request Jun 18, 2018

Luke Bjerring Chrome-bot
[idlharness.js] Add main interface as dep for implements
Case was revealed by #9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b

aarongable pushed a commit to chromium/chromium that referenced this pull request Jun 18, 2018

Luke Bjerring Commit Bot
[idlharness.js] Add main interface as dep for implements
Case was revealed by web-platform-tests/wpt#9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b
Reviewed-on: https://chromium-review.googlesource.com/1104707
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568143}

chromium-wpt-export-bot pushed a commit that referenced this pull request Jun 18, 2018

Luke Bjerring Chrome-bot
[idlharness.js] Add main interface as dep for implements
Case was revealed by #9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b
Reviewed-on: https://chromium-review.googlesource.com/1104707
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568143}

chromium-wpt-export-bot added a commit that referenced this pull request Jun 18, 2018

[idlharness.js] Add main interface as dep for implements
Case was revealed by #9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b
Reviewed-on: https://chromium-review.googlesource.com/1104707
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568143}

@lukebjerring lukebjerring merged commit 2052baf into web-platform-tests:master Jun 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring moved this from In progress to Done in Auto-import IDL files Jun 19, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 11, 2018

Bug 1469458 [wpt PR 11555] - [idlharness.js] Add main interface as de…
…p for implements, a=testonly

Automatic update from web-platform-tests[idlharness.js] Add main interface as dep for implements

Case was revealed by web-platform-tests/wpt#9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b
Reviewed-on: https://chromium-review.googlesource.com/1104707
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568143}

--

wpt-commits: f9b53c84450f825d0b7dffb942d75db043fa3ae4
wpt-pr: 11555

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Jul 13, 2018

Bug 1469458 [wpt PR 11555] - [idlharness.js] Add main interface as de…
…p for implements, a=testonly

Automatic update from web-platform-tests[idlharness.js] Add main interface as dep for implements

Case was revealed by web-platform-tests/wpt#9794
Specifically, Navigator implements NavigatorUserMedia;

Navigator was not being added as a depenedency, and thus was not being imported.

Change-Id: I07436c561bb0b567a431393a20f6a179ef5b364b
Reviewed-on: https://chromium-review.googlesource.com/1104707
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568143}

--

wpt-commits: f9b53c84450f825d0b7dffb942d75db043fa3ae4
wpt-pr: 11555

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-mediacapture-main branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.