Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payment-handler IDL file #9796

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 3, 2018

Build PASSED

Started: 2018-03-08 03:25:21
Finished: 2018-03-08 03:33:06

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-payment-handler branch from e789e23 to 0da0016 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 27, 2018

// https://w3c.github.io/payment-handler/

promise_test(async () => {
const idl = await fetch('/interfaces/payment-handler.idl').then(r => r.text());

This comment has been minimized.

Copy link
@marcoscaceres

marcoscaceres Jun 28, 2018

Contributor

How about:

const [idl, sw, dw, dom] = Promise.all([
  fetch("/interfaces/ServiceWorker.idl").then(r => r.text()),
  fetch("/interfaces/dedicated-workers.idl").then(r => r.text()),
  fetch("/interfaces/payment-handler.idl").then(r => r.text()),
  fetch("/interfaces/dom.idl").then(r => r.text()),
]);

This comment has been minimized.

Copy link
@marcoscaceres

marcoscaceres Jun 28, 2018

Contributor

Or, probably better (just trying to avoid downloading in sequence):

const idls = [
  "/interfaces/ServiceWorker.idl",
  "/interfaces/dedicated-workers.idl",
  "/interfaces/payment-handler.idl",
  "/interfaces/dom.idl",
];
const [idl, sw, dw, dom] = Promise.all(
  idls.map(url => fetch(url).then(r => r.text()))
);

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 28, 2018

Author Contributor

Done (the pattern you see in the update I've actually used all over the show for other tests, not sure why I dropped the ball here).

@marcoscaceres
Copy link
Contributor

marcoscaceres left a comment

Code looks good, but seems TravisCI failed.

@lukebjerring lukebjerring merged commit 4512702 into web-platform-tests:master Jun 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 29, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.