Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payment-request IDL file #9797

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 2, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 2, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 3, 2018

Build PASSED

Started: 2018-03-15 14:57:02
Finished: 2018-03-15 15:00:58

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-payment-request branch from 8410f09 to 72f4797 Mar 7, 2018

@foolip
Copy link
Contributor

foolip left a comment

Indentation

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-payment-request branch from 6edde0f to 1e340bd Mar 14, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 14, 2018

Whitespace handled - There's actually a couple of inconsistencies in the source indentation(s), but I don't want to generalize the stripping algorithm; better to tweak the source.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 14, 2018

Can you see if that is fixed by stripping leading whitespace for each individual IDL fragment before concatenating? If people are indenting to match the nesting in the source one would expect such inconsistencies, and that they'd not want to fix them either.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-payment-request branch from 1e340bd to 935215a Mar 15, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 15, 2018

Changed to per-snippet in GoogleChromeLabs/webidl-diff@71954d8 which resolves the problem.

@foolip

foolip approved these changes Mar 21, 2018

@foolip foolip merged commit ab293a5 into web-platform-tests:master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.