Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream ConvolverNode tests to WPT #9798

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 2, 2018

Add thresholds to allow for differences in expected results.

Needed for Firefox to pass the tests. Thresholds were set using
Firefox on Linux. Where the tests pass, the output looks correct
except for small numerical differences.

Bug: 745778
Change-Id: I8fa6582ac960922e777d83d9debc71aa36e1741b
Reviewed-on: https://chromium-review.googlesource.com/947096
Reviewed-by: Hongchan Choi hongchan@chromium.org
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/heads/master@{#541318}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-947096 branch from b754162 to 899981b Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-07 04:15:49
Finished: 2018-03-07 04:24:07

Failing Jobs

  • MicrosoftEdge:16.16299

Unstable Results

Browser: "Microsoftedge 16.16299" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade.html   TIMEOUT: 2
ERROR: 8
  > [cascade-mono] Cascaded mono convolvers PASS: 8

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-947096 branch from 899981b to df5be05 Mar 5, 2018

Upstream ConvolverNode tests to WPT
Add thresholds to allow for differences in expected results.

Needed for Firefox to pass the tests.  Thresholds were set using
Firefox on Linux.  Where the tests pass, the output looks correct
except for small numerical differences.

Bug: 745778
Change-Id: I8fa6582ac960922e777d83d9debc71aa36e1741b
Reviewed-on: https://chromium-review.googlesource.com/947096
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541318}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-947096 branch from df5be05 to 378e5d1 Mar 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 16376ce into master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-947096 branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.