Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Fix crash when appending var refs. #9801

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 4, 2018

We currently hit a DCHECK when appending a var ref. This patch fixes
the crash by rejecting it as per the spec.

Spec: w3c/css-houdini-drafts@ecfcbf9

Bug: 814606
Change-Id: I144307bf489db5e968c8e326087d13554ec3e59c
Reviewed-on: https://chromium-review.googlesource.com/948142
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#540938}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 4, 2018

Build PASSED

Started: 2018-03-06 11:49:41
Finished: 2018-03-06 11:55:18

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-948142 branch from 625ebeb to 30eaf73 Mar 5, 2018

[css-typed-om] Fix crash when appending var refs.
We currently hit a DCHECK when appending a var ref. This patch fixes
the crash by rejecting it as per the spec.

Spec: w3c/css-houdini-drafts@ecfcbf9

Bug: 814606
Change-Id: I144307bf489db5e968c8e326087d13554ec3e59c
Reviewed-on: https://chromium-review.googlesource.com/948142
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540938}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-948142 branch from 30eaf73 to 9f7a7bb Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c7860ca into master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-948142 branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.