Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MacOS, search for Firefox binary in common paths (Fixes #7125) #9806

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@reuben
Copy link
Contributor

reuben commented Mar 5, 2018

I chose to make PATH override the common installation folders, my thinking is if the user put Firefox in PATH they probably want that one to be used. This picks up Nightly first, then Dev Edition, then Beta/Stable.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 5, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-05 12:17:40
Finished: 2018-03-05 12:31:43

View more information about this build on:

@jgraham

jgraham approved these changes Mar 8, 2018

@jgraham jgraham merged commit 38aab7a into web-platform-tests:master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.