Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the permissions IDL file #9810

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 03:59:31
Finished: 2018-03-08 04:10:07

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-permissions branch from fdd223f to 1f34755 Mar 7, 2018

@Honry

This comment has been minimized.

Copy link
Contributor

Honry commented Mar 13, 2018

Dup of #9301

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 6, 2018

@Honry - this PR trivially pulls https://github.com/tidoust/reffy-reports/blob/master/whatwg/idl/permissions.idl

Could you append the header in that to your PR (#9301), so the next update is a no-op?

@Honry

This comment has been minimized.

Copy link
Contributor

Honry commented Jun 7, 2018

@lukebjerring, we've landed #9301, I think we can close it now. :)

@Honry Honry closed this Jun 7, 2018

@lukebjerring lukebjerring requested review from foolip and Honry Jun 26, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 26, 2018

@Honry - reopened because I used the same local branch (now up to date after #9301)

This change to the test fixes the current issue in all non-chrome browsers:
https://label-param-dot-wptdashboard-staging.appspot.com/results/permissions/interfaces.any.worker.html?sha=d093f88ec3

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jun 26, 2018

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@@ -11,18 +11,20 @@ if (self.importScripts) {
// https://w3c.github.io/permissions/#idl-index

promise_test(async () => {
const idl = await fetch("/interfaces/permissions.idl").then(r => r.text());
const dom = await fetch("/interfaces/dom.idl").then(r => r.text());

This comment has been minimized.

Copy link
@marcoscaceres

marcoscaceres Jun 26, 2018

Contributor

Nit:... these can sometimes contain things that some browsers don't support... like AbortController. This means that tests fail, but for the wrong reasons.

I don't know that the right approach is here...


self.permissionStatus = await navigator.permissions.query({ name: "geolocation" });
idl_array.add_idls(idl);
idl_array.add_dependency_idls(dom);

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 26, 2018

Author Contributor

@marcoscaceres - In response to your comment above, this is the helper method that avoids pulling in IDL that isn't relevant to the current test (i.e., only pulls in IDL which has been referenced by the IDL that has been added so far, such as inherited interfaces). So, while things like AbortController can be a problem, they're ignored unless the contents of permissions.idl reference them.

@lukebjerring lukebjerring merged commit e1cdfb8 into web-platform-tests:master Jun 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 29, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-permissions branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.