Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pointerlock IDL file #9813

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 04:33:16
Finished: 2018-03-08 04:42:13

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-pointerlock branch from 44641b4 to 962dfbc Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

Can you update this with the indentation fixes?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-pointerlock branch from 962dfbc to 028e4a9 Apr 5, 2018

@wpt-pr-bot wpt-pr-bot requested review from scheib and siusin Apr 5, 2018

@lukebjerring lukebjerring requested review from foolip and removed request for scheib and siusin Apr 5, 2018

@foolip

foolip approved these changes Apr 5, 2018

Copy link
Contributor

foolip left a comment

Lint is unhappy with trailing whitespace somewhere, but otherwise LGTM.

idl_array.add_objects({
Document: ["window.document"],
Element: ["window.document.documentElement"],
MouseEvent: ["new MouseEvent('mousemove')", "new MouseEvent('pointerlockchange')"]

This comment has been minimized.

Copy link
@foolip

foolip Apr 5, 2018

Contributor

This was preexisting, but I think that testing two MouseEvent instances that only differ by the value of the type attribute gets no extra coverage. Optional cleanup in other words.

@wpt-pr-bot wpt-pr-bot requested review from scheib and siusin Apr 5, 2018

@foolip

foolip approved these changes May 28, 2018

Copy link
Contributor

foolip left a comment

LGTM % extra instance

idl_array.add_objects({
Document: ["window.document"],
Element: ["window.document.documentElement"],
MouseEvent: ["new MouseEvent('mousemove')", "new MouseEvent('pointerlockchange')"]

This comment has been minimized.

Copy link
@foolip

foolip May 28, 2018

Contributor

Not new, but this doesn't provide any additional coverage since the only thing it will affect is the value of the event.type, which idlharness.js can assume nothing about anyway. Just one instance will be less confusing. Type 'foo' might make it clearer that it doesn't matter.

@lukebjerring lukebjerring merged commit 9fea339 into web-platform-tests:master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.