Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update the presentation-api IDL file #9814
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
There's one thing specific about the Presentation API that @tomoyukilabs pointed out and that seems worth emphasizing: the Presentation API defines two conformance classes (controlling UA and receiving UA), and the IDL that needs to be supported is different for each of them.
To test the IDL in a receiving UA, one needs to run the IDL harness within a receiving context. The corresponding (manual) test is in: receiving-ua/idlharness-manual.https.html. That file and its dependencies are not touched by this PR, and that's a good thing for now. But that also means the receiving IDL is still being maintained manually (in receiving-ua/support/idlharness_receiving-ua.html).
All in all, I believe we can merge as-is, although there are two things that we might want to do (either now or later on):
@lukebjerring I'm not sure what would make implementers' life easier. Would having separated IDL files be preferable, or is it fine to maintain a list of false positives?
We have a function param which supports filtering only some of the IDL (blacklist or whitelist both supported). Happy to set the test up that way.
How would I tell what's what? By looking at the inlined IDL before my changes?
EDIT: Yeah that's exactly how I could tell, so have excluded