Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computed min-width/height for auto depends on box. #9816

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 5, 2018

Resolved value of min-width and min-height for auto min sizing of flex
and grid items may be 'auto'. We based this on the computed style of the
shadow including parent. Instead we should rely on whether the element
will actually be a rendered flex/grid item.

Firefox Nightly passes all added tests.

The mentioned bug fixed is actually about using the shadow including
parent for finding parent computed style instead of the flat tree
parent, but that is no longer relevant as we look at the layout tree.

Bug: 682869
Change-Id: I6e47dc264a8cdbee7fc1983ce452baf7c0df85b3
Reviewed-on: https://chromium-review.googlesource.com/948908
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#540901}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-06 11:49:28
Finished: 2018-03-06 11:54:44

Failing Jobs

  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Computed min-width/height for auto depends on box.
Resolved value of min-width and min-height for auto min sizing of flex
and grid items may be 'auto'. We based this on the computed style of the
shadow including parent. Instead we should rely on whether the element
will actually be a rendered flex/grid item.

Firefox Nightly passes all added tests.

The mentioned bug fixed is actually about using the shadow including
parent for finding parent computed style instead of the flat tree
parent, but that is no longer relevant as we look at the layout tree.

Bug: 682869
Change-Id: I6e47dc264a8cdbee7fc1983ce452baf7c0df85b3
Reviewed-on: https://chromium-review.googlesource.com/948908
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540901}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-948908 branch from b11ff15 to a0dee15 Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 85247f1 into master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-948908 branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.