Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests of non-defined behaviors for `line-break: loose` #9817

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 5, 2018

These tests test behavior for line-break: loose as described
in JLREQ, a Note that describes traditional Japanese typography,
published by W3C i18n WG, but not in Unicode UAX#14 Line
Breaking Algorithm nor in CSS Text Level 3 line-break: loose.

They were considered and discussed in WG, but they do not fit well
with multi-lingual typography. Also because most traditional
Japanese typography used to use their fullwidth counterpart, the
values are limited, and that they did not make into the specs.

Gecko fails these tests too according to the test results:
http://test.csswg.org/harness/results/css-text-3_dev/grouped/

U+003A is IS
css3-text-line-break-jazh-136.html
css3-text-line-break-jazh-356.html
U+003B is IS
css3-text-line-break-jazh-137.html
css3-text-line-break-jazh-357.html
U+0021 is EX
css3-text-line-break-jazh-142.html
css3-text-line-break-jazh-360.html
U+003F is EX
css3-text-line-break-jazh-143.html
css3-text-line-break-jazh-361.html
U+0025 is PO
css3-text-line-break-jazh-150.html
css3-text-line-break-jazh-368.html
css3-text-line-break-jazh-371.html
U+00A2 is PO
css3-text-line-break-jazh-151.html
css3-text-line-break-jazh-369.html

Bug: 817773
Change-Id: Iec38bffb0f74e82f5527313693b335ab8097d492
Reviewed-on: https://chromium-review.googlesource.com/948682
Reviewed-by: Emil A Eklund eae@chromium.org
Commit-Queue: Emil A Eklund eae@chromium.org
Cr-Commit-Position: refs/heads/master@{#540865}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-05 20:14:02
Finished: 2018-03-05 20:22:00

View more information about this build on:

Remove tests of non-defined behaviors for `line-break: loose`
These tests test behavior for [line-break: loose] as described
in [JLREQ], a Note that describes traditional Japanese typography,
published by W3C i18n WG, but not in Unicode [UAX#14] Line
Breaking Algorithm nor in CSS Text Level 3 [line-break: loose].

They were considered and discussed in WG, but they do not fit well
with multi-lingual typography. Also because most traditional
Japanese typography used to use their fullwidth counterpart, the
values are limited, and that they did not make into the specs.

Gecko fails these tests too according to the test results:
http://test.csswg.org/harness/results/css-text-3_dev/grouped/

U+003A is `IS`
  css3-text-line-break-jazh-136.html
  css3-text-line-break-jazh-356.html
U+003B is `IS`
  css3-text-line-break-jazh-137.html
  css3-text-line-break-jazh-357.html
U+0021 is `EX`
  css3-text-line-break-jazh-142.html
  css3-text-line-break-jazh-360.html
U+003F is `EX`
  css3-text-line-break-jazh-143.html
  css3-text-line-break-jazh-361.html
U+0025 is `PO`
  css3-text-line-break-jazh-150.html
  css3-text-line-break-jazh-368.html
  css3-text-line-break-jazh-371.html
U+00A2 is `PO`
  css3-text-line-break-jazh-151.html
  css3-text-line-break-jazh-369.html

[JLREQ]: https://www.w3.org/TR/jlreq/
[UAX#14]: http://unicode.org/reports/tr14/
[line-break: loose]: https://drafts.csswg.org/css-text-3/#valdef-line-break-loose

Bug: 817773
Change-Id: Iec38bffb0f74e82f5527313693b335ab8097d492
Reviewed-on: https://chromium-review.googlesource.com/948682
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540865}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-948682 branch from c0d744e to 016067a Mar 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3aaf2b4 into master Mar 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-948682 branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.