Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fonts. Includes the CSSTest folder that was under /css #9818

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@r12a
Copy link
Contributor

r12a commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot added the assets label Mar 5, 2018

@wpt-pr-bot wpt-pr-bot requested a review from gsnedders Mar 5, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Mar 5, 2018

Note this is essentially a subset of #9718

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build ERRORED

Started: 2018-03-05 18:25:11
Finished: 2018-03-05 18:35:16

Failing Jobs

  • lint
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Mar 12, 2018

All these fonts were moved to /fonts in #9718, so this isn't needed.

Note the following are in different paths compared with this branch:

fonts/CSSTest/mplus-1p-regular.woff
fonts/noto/NotoNaskhArabic-regular.woff2
fonts/noto/NotoSansArmenian-regular.woff2
fonts/noto/NotoSansCherokee-regular.woff2
fonts/noto/NotoSansDeseret-regular.woff2
fonts/noto/NotoSansGeorgian-regular.woff2
fonts/noto/NotoSansMongolian-regular.woff2
fonts/noto/NotoSerifDevanagari-regular.woff2
fonts/noto/NotoSerifHebrew-regular.woff2
fonts/sil/DoulosSIL-regular.woff2
fonts/sil/GentiumPlus-regular.woff2
fonts/sil/Scheherazade-regular.woff2

The various SIL International fonts are directly in /fonts, mplus-1p-regular.woff is directly in /fonts. Though seemingly you added some Noto fonts that still aren't here? You should probably just add those to #9871 if those rely on it.

@gsnedders gsnedders closed this Mar 12, 2018

@wpt-pr-bot wpt-pr-bot requested review from fantasai and kojiishi Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.