Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap Point selection should satisfy visibility requirement. #9821

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 5, 2018

According to spec, https://www.w3.org/TR/css-scroll-snap-1/#snap-scope
we should only consider the snap points of visible snap areas.
This patch implements the visibility requirement by adding a field of
visible region for each snap point. It also handles the case of
visibility conflict when snapping to two axes individually.

Bug: 778257
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I7a3d2aa6b9c1293df3f05118152f105fa3265d29
Reviewed-on: https://chromium-review.googlesource.com/814874
Commit-Queue: Sandra Sun sunyunjia@chromium.org
Reviewed-by: Jeremy Roman jbroman@chromium.org
Reviewed-by: Ali Juma ajuma@chromium.org
Reviewed-by: Majid Valipour majidvp@chromium.org
Cr-Commit-Position: refs/heads/master@{#543111}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-814874 branch from 341ac9a to 5e9160b Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-14 17:58:41
Finished: 2018-03-14 18:02:50

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-814874 branch 5 times, most recently from 027a1a6 to 9f830b0 Mar 9, 2018

Snap Point selection should satisfy visibility requirement.
According to spec, https://www.w3.org/TR/css-scroll-snap-1/#snap-scope
we should only consider the snap points of visible snap areas.
This patch implements the visibility requirement by adding a field of
visible region for each snap point. It also handles the case of
visibility conflict when snapping to two axes individually.

Bug: 778257
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I7a3d2aa6b9c1293df3f05118152f105fa3265d29
Reviewed-on: https://chromium-review.googlesource.com/814874
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543111}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-814874 branch from 9f830b0 to 4fad1eb Mar 14, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 343fd25 into master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-814874 branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.