Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move merger/splitter tests to WPT #9823

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 5, 2018

Move the ChannelMerger and ChannelSplitter tests to WPT.
ChannelSplitteraudiochannelsplitter.html removed from SmokeTests.

Note that ChannelMerger/audiochannelmerger-cycle.html isn't moved.
Firefox currently fails this test, but I think Firefox is correct and
Chrome is wrong. We'll move this test later.

Bug: 745778
Change-Id: I981a773a9c654f26d15e80eb5ec699b0eca0c8d7
Reviewed-on: https://chromium-review.googlesource.com/949053
Reviewed-by: Hongchan Choi hongchan@chromium.org
Reviewed-by: Robert Ma robertma@chromium.org
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/heads/master@{#541508}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-949053 branch from 55f313e to 31e7f4e Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-07 18:34:26
Finished: 2018-03-07 18:39:13

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-949053 branch from 31e7f4e to fe24a00 Mar 7, 2018

Move merger/splitter tests to WPT
Move the ChannelMerger and ChannelSplitter tests to WPT.
ChannelSplitteraudiochannelsplitter.html removed from SmokeTests.

Note that ChannelMerger/audiochannelmerger-cycle.html isn't moved.
Firefox currently fails this test, but I think Firefox is correct and
Chrome is wrong.  We'll move this test later.

Bug: 745778
Change-Id: I981a773a9c654f26d15e80eb5ec699b0eca0c8d7
Reviewed-on: https://chromium-review.googlesource.com/949053
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541508}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-949053 branch from fe24a00 to 5a0a278 Mar 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2e16103 into master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-949053 branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.