Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the screen-orientation IDL file #9827

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-14 15:46:05
Finished: 2018-03-14 15:52:32

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-screen-orientation branch from 3151892 to 17132a0 Mar 7, 2018

@foolip
Copy link
Contributor

foolip left a comment

Indentation needs collapsing here too. (People will read these in order to understand test failures, so it's not just input for the tests.)

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-screen-orientation branch from 06a6908 to 5b1fc87 Mar 14, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 14, 2018

Added indent leading spaces trimming in GoogleChromeLabs/webidl-diff@aaaf4d3 .

PTAL.

@foolip

foolip approved these changes Mar 14, 2018

@foolip foolip merged commit 6534d85 into web-platform-tests:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.