Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the scroll-animations IDL file #9828

Conversation

6 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 05:37:13
Finished: 2018-03-08 05:48:39

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-scroll-animations branch from 832803c to 5aca4c3 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

Luke Bjerring

@lukebjerring lukebjerring requested a review from foolip Jun 19, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 19, 2018

@foolip - Unsure about OWNERS. Also might need a tentative on the test? And where should the test go?

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 19, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 20, 2018

@birtles @theres-waldo @manta12, you are the editors listed in https://wicg.github.io/scroll-animations/ and show up in https://github.com/WICG/scroll-animations/graphs/contributors, so I added you as the suggested reviewers in META.yml. Can you confirm that you are OK with this? @theres-waldo @manta12, you'll also need to accept the invite to the web-platform-tests org to make this work.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 20, 2018

@lukebjerring this need not be tentative, even though https://wicg.github.io/scroll-animations/ says "Unofficial Proposal Draft" the IDL is still in the spec, and if it changes the test will. Tentative tests are rather for things which haven't been merged into any spec.

@foolip

foolip approved these changes Jun 20, 2018

Copy link
Contributor

foolip left a comment

Tests LGTM, but should await suggested reviewer OK before merging.

@theres-waldo

This comment has been minimized.

Copy link
Contributor

theres-waldo commented Jun 20, 2018

@birtles @theres-waldo @manta12, you are the editors listed in https://wicg.github.io/scroll-animations/ and show up in https://github.com/WICG/scroll-animations/graphs/contributors, so I added you as the suggested reviewers in META.yml. Can you confirm that you are OK with this?

I'm not entirely sure what's going on / what I'm supposed to be OK-ing.

The Scroll Animations spec is likely to undergo changes (possibly significant ones) before progressing further in the standards process. There are no web platform tests (or any other kind of tests) for it yet.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 20, 2018

@theres-waldo - details about the reason behind this PR are in the description - basically we're looking for someone to be able to eyeball changes to the IDL each time it auto-updates, and verify whether the idlharness.js test is covering the interface well enough.

@theres-waldo

This comment has been minimized.

Copy link
Contributor

theres-waldo commented Jun 20, 2018

we're looking for someone to be able to eyeball changes to the IDL each time it auto-updates

Ok, the three of us added as suggested reviewers are appropriate for that.

and verify whether the idlharness.js test is covering the interface well enough

This part I don't entirely follow. Is the idea that something generates tests based on the IDL alone?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 20, 2018

Yes, idlharness.js is a framework in WPT for automatically generating a test suite based on the IDL itself, and some instances/JS objects which implement that IDL.

The latter - making JS objects which implement the IDL - is often fairly niche/esoteric knowledge, so having the right pair of eyeballs on it can help a lot.

@lukebjerring lukebjerring merged commit 7871fd1 into web-platform-tests:master Jun 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 20, 2018

@theres-waldo

This comment has been minimized.

Copy link
Contributor

theres-waldo commented Jun 20, 2018

Ok, so in this case, is there some generated JS code that implements the ScrollTimeline interface? Where is that?

idl_array.add_dependency_idls(web);
idl_array.add_dependency_idls(dom);
idl_array.add_objects({
ScrollTimeline: ['new ScrollTimeline()'],

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 20, 2018

Author Contributor

@theres-waldo - to clarify, the JS object is not auto-generated, it's just created inline, here.

@wpt-pr-bot wpt-pr-bot requested review from birtles and theres-waldo Jun 20, 2018

@birtles
Copy link
Contributor

birtles left a comment

Looks good with the updates to the reviewer list made.

suggested_reviewers:
- birtles
- theres-waldo
- manta12

This comment has been minimized.

Copy link
@birtles

birtles Jun 20, 2018

Contributor

Mantaroh is less involved in this spec recently so I think it's not necessary to include him.

This comment has been minimized.

Copy link
@foolip

foolip Jun 21, 2018

Contributor

OK, I'll remove him again.

foolip added a commit that referenced this pull request Jun 21, 2018

birtles added a commit that referenced this pull request Jun 22, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 26, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 11, 2018

Bug 1470104 [wpt PR 11602] - Remove @manta12 from scroll-animations/M…
…ETA.yml, a=testonly

Automatic update from web-platform-testsRemove @manta12 from scroll-animations/META.yml (#11602)

Per web-platform-tests/wpt#9828 (comment).
--

wpt-commits: 920152c5b30a12bc3aac3783e886ddaf997756c3
wpt-pr: 11602

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Jul 13, 2018

Bug 1470104 [wpt PR 11602] - Remove @manta12 from scroll-animations/M…
…ETA.yml, a=testonly

Automatic update from web-platform-testsRemove @manta12 from scroll-animations/META.yml (#11602)

Per web-platform-tests/wpt#9828 (comment).
--

wpt-commits: 920152c5b30a12bc3aac3783e886ddaf997756c3
wpt-pr: 11602

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-scroll-animations branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.