Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the selection-api IDL file #9829

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 23:44:58
Finished: 2018-03-08 23:54:26

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-selection-api branch 6 times, most recently from c168eac to 7f1adaf Mar 7, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-selection-api branch from 7f1adaf to 9ce9803 Mar 8, 2018

@foolip

foolip approved these changes Apr 6, 2018

Copy link
Contributor

foolip left a comment

LGTM % whitespace and checking that selection/interfaces.html isn't broken.

partial interface Document {
Selection? getSelection();
};
interface Selection {

This comment has been minimized.

Copy link
@foolip

foolip Apr 6, 2018

Contributor

Can you update this with the whitespace stripping fixes?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented May 23, 2018

@foolip - this is now clearly a no-op after the latest scrape, merge if you're happy.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented May 23, 2018

I am very happy :)

@foolip foolip merged commit 79e45ec into web-platform-tests:master May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.