Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the server-timing IDL file #9831

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 05:55:18
Finished: 2018-03-08 06:03:27

View more information about this build on:

Luke Bjerring added some commits Mar 2, 2018

Luke Bjerring
Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-server-timing branch from 4d80e88 to 1a1e0a4 Mar 7, 2018

@lukebjerring lukebjerring requested a review from foolip Jun 14, 2018

idl_array.add_dependency_idls(res);
idl_array.add_dependency_idls(perf);
idl_array.add_objects({
Performance: ['performance'],

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 14, 2018

Author Contributor

@npm1 - how would I go about getting a serverTiming object for the IDL harness to test?
I was looking at https://developer.mozilla.org/en-US/docs/Web/API/PerformanceServerTiming and tried

performance.getEntriesByType('resource')[0].serverTiming

But, it's empty (presumably because the headers aren't attached to the response).

This comment has been minimized.

Copy link
@npm1

npm1 Jun 14, 2018

Contributor

Maybe try performance.getEntriesByType('navigation')[0].serverTiming

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 14, 2018

Author Contributor

Also doesn't exist. Might land this as-is and add it (an object) at a later date.

foolip added some commits Jun 14, 2018

@foolip

foolip approved these changes Jun 14, 2018

Copy link
Contributor

foolip left a comment

Removed two done() that I think wouldn't do anything, or worse perhaps do something unwanted, otherwise LGTM.

@lukebjerring lukebjerring merged commit 55c9a77 into web-platform-tests:master Jun 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.