Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the user-timing IDL file #9837

Merged

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-user-timing branch from ef9001d to b294daa Mar 7, 2018

@@ -0,0 +1,17 @@

partial interface Performance {

This comment has been minimized.

Copy link
@foolip

foolip Mar 21, 2018

Contributor

Can you update to strip the indentation and use the file in https://github.com/w3c/web-platform-tests/blob/master/user-timing/idlharness.html?

This comment has been minimized.

Copy link
@foolip

foolip May 23, 2018

Contributor

@lukebjerring, indentation problem still persists.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

Hmm, and why is Travis unhappy?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 5, 2018

@lukebjerring looks like this needs a test to exercise the IDL?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 6, 2018

I've updated the user-timing/idlharness.html test to be .any.js, since it's exposed on both worker + window, and changed the test to use the IDL. PTAL.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 6, 2018

cc @npm1 who was helping me work out whether using .any.js was the right thing to do. Note that we see a large number of .any.worker.html results with:

assert_own_property: self does not have own property "PerformanceMark" expected property "PerformanceMark" missing

Goes a bit beyond my understanding of the implementation of idlharness. @foolip - any idea whether that's to be expected?

promise_test(async () => {
const idl_array = new IdlArray();
const idl = await fetch("/interfaces/user-timing.idl").then(r => r.text());
const hrtime = await fetch("/interfaces/hr-time.idl").then(r => r.text());

This comment has been minimized.

Copy link
@plehegar

plehegar Jun 6, 2018

Contributor

you need to import /interfaces/performance-timeline.idl as well, since PerformanceMark depends on PerformanceEntry.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 6, 2018

Author Contributor

Alright, I'll pull in #9809 to this PR.

@foolip

foolip approved these changes Jun 8, 2018

Copy link
Contributor

foolip left a comment

Tested locally, .worker.html tests will reveal some things that don't match the spec in Chromium :) 👍

@foolip foolip merged commit 8cce357 into web-platform-tests:master Jun 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.