Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the web-audio-api IDL file #9839

Merged

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-29 18:17:25
Finished: 2018-03-29 18:25:12

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-audio-api branch from 52d0027 to 3686e4e Mar 7, 2018

@foolip
Copy link
Contributor

foolip left a comment

Looks like there's already an IDL file just by a different name. Can you update https://github.com/w3c/web-platform-tests/blob/master/webaudio/idlharness.https.html and delete the old file?

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-audio-api branch from 3686e4e to 77d3b57 Mar 28, 2018

@wpt-pr-bot wpt-pr-bot requested review from chrislo, padenot and rtoy Mar 28, 2018

].map(url => fetch(url).then(response => response.text())));
const idl_array = new IdlArray();
// Dependencies of HTML
idl_array.add_untested_idls(html, { only: ['EventTarget', 'HTMLMediaElement']});
idl_array.add_untested_idls(dom, { only: ['Event', 'EventListener']});
idl_array.add_untested_idls(mediacapture, { only: ['MediaStream', 'MediaStreamTrack']});

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 28, 2018

Author Contributor

It's hard to test these changes actually work, since the test fails hard with

promise_test: Unhandled rejection with value: object "TypeError: context.audioWorklet is undefined"

(both Chrome + Firefox)

This comment has been minimized.

Copy link
@foolip

foolip Mar 28, 2018

Contributor

Ah. So the problem is the code that ends up with the worklet_node variable is unguarded, and if it fails the whole test does. The fix would be to guard that somehow (if or try/catch) and to not add the AudioParamMap and AudioWorkletNode instances if no instances could be created.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 29, 2018

Author Contributor

Welp, you successfully deterred me from trying to clean anything up.

Reverted the change to the URL of the file only, to make this a clean PR.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-audio-api branch from 77d3b57 to 176180e Mar 29, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 29, 2018

PTAL (change is now a file rename and a comment).

@foolip

foolip approved these changes Mar 30, 2018

@foolip foolip merged commit 067f918 into web-platform-tests:master Mar 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.