Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the web-bluetooth IDL file #9840

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 07:27:27
Finished: 2018-03-08 07:36:53

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-bluetooth branch from 87096ce to 4f1dc35 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 20, 2018

Luke Bjerring

@lukebjerring lukebjerring requested review from foolip and removed request for jensl and yuki3 Jun 20, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Jun 20, 2018

There's a spec-wpt name mismatch here, https://github.com/web-platform-tests/wpt/tree/master/bluetooth is the existing directory. If you move the test into there, you'll get some reviewers.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jun 20, 2018

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip

foolip approved these changes Jun 20, 2018

Copy link
Contributor

foolip left a comment

LGTM % directory.

Luke Bjerring

@wpt-pr-bot wpt-pr-bot requested review from g-ortuno, jyasskin and scheib Jun 20, 2018

@lukebjerring lukebjerring merged commit 1786c35 into web-platform-tests:master Jun 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 20, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.