Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the webmidi IDL file + test #9841

Merged

Conversation

5 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 07:35:42
Finished: 2018-03-08 07:44:44

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-midi-api branch from 748790b to 55ff7d2 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 28, 2018

@lukebjerring lukebjerring removed request for jensl and yuki3 Jun 28, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 28, 2018

@cwilso - can you take a look?

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Jun 28, 2018

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jul 4, 2018

@jussi-kalliokoski are you able to take a look?

@lukebjerring lukebjerring requested a review from foolip Jul 24, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-midi-api branch from 4831df1 to cfae5d8 Jul 24, 2018

@foolip

foolip approved these changes Jul 24, 2018

@@ -0,0 +1,4 @@
spec: https://webaudio.github.io/web-midi-api/
suggested_reviewers:
- cwilso

This comment has been minimized.

Copy link
@foolip

foolip Jul 24, 2018

Contributor

@cwilso @jussi-kalliokoski, I've sent org invites which you can accept at https://github.com/web-platform-tests. If you don't want to review tests for Web MIDI in this repo, can you suggest some good candidates?

This comment has been minimized.

Copy link
@cwilso

cwilso Aug 2, 2018

I'll review. Sorry, been kinda backed up.

@cwilso

cwilso approved these changes Aug 2, 2018

Copy link

cwilso left a comment

LGTM.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-web-midi-api branch from cfae5d8 to 7c37dd9 Aug 3, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Aug 3, 2018

@foolip - rejigged to use idl_test. PTAL. I also threw the input and output objects behind an if statement, since we make no effort to automate these (yet).

@cwilso is there any existing automation for testing around, say, virtual/software devices?

foolip added some commits Aug 3, 2018

@foolip

foolip approved these changes Aug 3, 2018

Copy link
Contributor

foolip left a comment

@foolip foolip changed the title Update the web-midi-api IDL file Add the webmidi IDL file + test Aug 3, 2018

@foolip foolip merged commit e9a34c1 into web-platform-tests:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Aug 3, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-web-midi-api branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.