Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webappsec-credential-management IDL file #9844

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 08:02:34
Finished: 2018-03-08 08:11:32

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webappsec-credential-management branch from 909686e to c644d41 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 27, 2018

@lukebjerring lukebjerring requested a review from foolip Jun 27, 2018

@wpt-pr-bot wpt-pr-bot requested review from apowers313, jcjones and mikewest Jun 27, 2018

@lukebjerring lukebjerring requested review from mikewest and removed request for mikewest, jensl, jcjones, apowers313 and yuki3 Jun 27, 2018

@mikewest
Copy link
Contributor

mikewest left a comment

LGTM, thanks!

@mikewest mikewest merged commit 89e834c into web-platform-tests:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jun 28, 2018

lukebjerring added a commit to lukebjerring/wpt that referenced this pull request Jun 29, 2018

Update the webappsec-credential-management IDL file (web-platform-tes…
…ts#9844)

* Add webappsec-credential-management idl file

* Updated webappsec-credential-management IDL file

* Clean up tests

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-webappsec-credential-management branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.