Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webappsec-csp-embedded IDL file #9846

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 08:11:36
Finished: 2018-03-08 08:18:55

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webappsec-csp-embedded branch from 70ea632 to 0432567 Mar 7, 2018

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jun 18, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jun 18, 2018

@wpt-pr-bot wpt-pr-bot requested a review from hillbrad Jun 26, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jun 26, 2018

@lukebjerring lukebjerring requested review from foolip and removed request for jensl and yuki3 Jun 26, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 26, 2018

@hillbrad - can you just check that the auto-scraped IDL looks as expected?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 29, 2018

Geez.. sorry for the spam all. Unsquashed master merge + overeager wpt-bot is a bad combo.

@foolip

foolip approved these changes Jul 16, 2018

Copy link
Contributor

foolip left a comment

Spotted and fixed a typo, so not merging so that it can go through Travis and for @lukebjerring to check that the test is working. (On Chromebook.)

@lukebjerring lukebjerring merged commit 8fca2b5 into web-platform-tests:master Jul 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jul 16, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jul 16, 2018

Good catch; tested locally and there's now 5 tests passing in Chrome 67

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-webappsec-csp-embedded branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.