Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webappsec-referrer-policy IDL file #9847

Conversation

4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-08 08:19:29
Finished: 2018-03-08 08:27:17

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webappsec-referrer-policy branch from 10ff1a0 to 36f8282 Mar 7, 2018

@csnardi

This comment has been minimized.

Copy link
Member

csnardi commented May 24, 2018

Could you also add this file as an untested (or I guess dependency would work now) IDL instead of https://github.com/w3c/web-platform-tests/blob/master/fetch/api/idl.any.js#L11?

(We need that change in order to land a webidl2.js update, as we currently use invalid IDL (an empty enum), and newer versions of webidl2.js show that as a syntax error.)

@csnardi

This comment has been minimized.

Copy link
Member

csnardi commented Jun 14, 2018

Actually, any reason not to just merge this as-is @lukebjerring? I can create a PR for the dependency, and I don't believe idlharness.js currently does anything with enums, so a test wouldn't be needed for the spec.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Jun 14, 2018

SGTM.

@csnardi csnardi merged commit 582057a into web-platform-tests:master Jun 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.