Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webauthn IDL file #9850

Merged

Conversation

5 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 5, 2018

Build PASSED

Started: 2018-03-29 17:27:08
Finished: 2018-03-29 17:35:34

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webauthn branch 2 times, most recently from 2b1626f to 45f94c4 Mar 7, 2018

@foolip

foolip approved these changes Mar 21, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 21, 2018

Before merging, can you check if the test still works?

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webauthn branch from 45f94c4 to 09609e7 Mar 23, 2018

@wpt-pr-bot wpt-pr-bot requested review from apowers313 and jcjones Mar 23, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 23, 2018

Looks like partial dictionary is causing problems:

promise_test: Unhandled rejection with value: "Duplicate identifier AuthenticationExtensionsClientInputs"

See #5714

@jcjones
Copy link
Contributor

jcjones left a comment

Test changes look good. And thanks for taking a stab at fixing the partial dictionary test issue!

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 23, 2018

Ran locally with #10159, and we get 51 subtests (of which 33 fail), so looks like that fix will help point out issues!

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webauthn branch from dae1be6 to e43a11f Mar 29, 2018

@lukebjerring lukebjerring merged commit 149116d into web-platform-tests:master Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-webauthn branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.