Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webdriver IDL file #9851

Merged

Conversation

@lukebjerring
Copy link
Contributor

commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

commented Mar 5, 2018

Build BROKEN

Started: 2018-03-08 08:55:28
Finished: 2018-03-08 09:03:05

Failing Jobs

  • lint
  • build_css
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webdriver branch from a4907db to 4117ea3 Mar 7, 2018

@foolip

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2018

@foolip
Copy link
Contributor

left a comment

IDL LGTM, but needs to be used in a test.

lukebjerring added some commits Jun 5, 2018

// extent, this test is a bit special. It should also be possible to
// run the test manually, when WebDriver is not active, and so either
// true/false outcome is OK.
if (navigator.webdriver) {

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 6, 2018

Author Contributor

Note that this test is basically "if true, assert true, else assert false" which will only fail when navigator.webdriver is undefined - which is a test that is already covered by the idlarray.add_objects({Navigator: ["navigator"]}) added below.
Hence, since it's confusing, I deleted it.

cc @kereliuk

<script>
"use strict";
test(() => assert_idl_attribute(navigator, "webdriver"), "navigator.webdriver is present");

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 6, 2018

Author Contributor

assert_idl_attribute is already covered by idlarray.test() below - hence, redundant, and deleted.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2018

Now used in a test, PTAL.

@andreastt
Copy link
Member

left a comment

This seems to streamline things a bit, and appears to be how other IDLs are tested.

However, I’d like to get the test running before I proceed with a more detailed review. See more comments inline.

@@ -1,49 +1,23 @@
<!doctype html>
<meta charset=utf-8>

<link rel="help" href="https://w3c.github.io/webdriver/webdriver-spec.html">

This comment has been minimized.

Copy link
@andreastt
idls.test();
"use strict";
promise_test(async () => {

This comment has been minimized.

Copy link
@andreastt

andreastt Jun 7, 2018

Member

I get this when running the test locally:

JavaScript error: file:///home/ato/src/wpt/webdriver/tests/interface.html, line 12: ReferenceError: promise_test is not defined

This comment has been minimized.

Copy link
@foolip

foolip Jun 7, 2018

Contributor

Looks like you're trying to run the test from file://. Please run wpt run and use http://web-platform.test:8000/webdriver/tests/interface.html instead.

This comment has been minimized.

Copy link
@andreastt

andreastt Jun 7, 2018

Member

That’s not what I want to test. I explicitly want the test to pass when loading it manually with WebDriver disabled.

This comment has been minimized.

Copy link
@foolip

foolip Jun 7, 2018

Contributor

Oops, I meant wpt serve. testharness.js tests can't be loaded over file:// is the important point.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jun 7, 2018

Author Contributor

As foolip said, from the wpt root, run ./wpt serve then head to http://localhost:8000/webdriver/tests/interface.html

This comment has been minimized.

Copy link
@andreastt

andreastt Jun 9, 2018

Member

Thanks, I can confirm it passes as expected both with and without Marionette enabled in Firefox.

@andreastt andreastt merged commit 418538e into web-platform-tests:master Jun 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andreastt

This comment has been minimized.

Copy link
Member

commented Jun 9, 2018

Please note that a better commit message would be appreciated next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.