Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the webrtc-pc IDL file #9853

Merged

Conversation

@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 5, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 5, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-29 14:26:08
Finished: 2018-03-29 14:30:45

View more information about this build on:

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webrtc-pc branch from e6ff7f2 to 4562bcc Mar 7, 2018

@foolip

foolip approved these changes Mar 21, 2018

Copy link
Contributor

foolip left a comment

The changes look reasonable. https://pulls.web-platform-tests.org/build/25558 isn't telling me anything useful, so before merging, can you check how https://github.com/w3c/web-platform-tests/blob/master/webrtc/interfaces.https.html is affected by the change, so that at least it's not now completely broken?

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webrtc-pc branch from 4562bcc to e07a06d Mar 28, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 28, 2018

Currently afflicted by #5714

Luke Bjerring and others added some commits Mar 2, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-webrtc-pc branch from e07a06d to c66a53d Mar 29, 2018

idlArray.add_untested_idls('interface EventHandler {};');
idlArray.add_idls('interface EventTarget {};');

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 29, 2018

Author Contributor

This is is example missing interface which had poor error messages (#10214)

@lukebjerring lukebjerring merged commit 8c66f53 into web-platform-tests:master Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-webrtc-pc branch Mar 29, 2018

@lukebjerring lukebjerring restored the lukebjerring:idl-file-updates-webrtc-pc branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.