Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct serialization of counter() #9862

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
4 participants
@csnardi
Copy link
Member

csnardi commented Mar 5, 2018

As discussed in w3c/csswg-drafts#670, the spec states that if the "the last CSS component value if it is "decimal"", it should be omitted when serializing. Correct the test to match the spec.

Fixes w3c/csswg-drafts#670.

Correct serialization of counter()
As discussed in w3c/csswg-drafts#670, the spec states that if the "the last CSS component value if it is "decimal"", it should be omitted when serializing. Correct the test to match the spec.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-07 01:48:58
Finished: 2018-03-07 01:55:50

View more information about this build on:

@emilio

emilio approved these changes Mar 7, 2018

Copy link
Contributor

emilio left a comment

Probably worth also testing { actual: 'counter(par-num, decimal)', serialized: 'counter(par-num)' }?

@emilio

This comment has been minimized.

Copy link
Contributor

emilio commented Mar 7, 2018

Let me know if you want to adjust the test to also test that case, otherwise looks fine to merge as-is to me.

@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Mar 7, 2018

@emilio Easy enough to add, should be good to merge now.

@emilio emilio merged commit 0933011 into web-platform-tests:master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emilio

This comment has been minimized.

Copy link
Contributor

emilio commented Mar 7, 2018

Thanks!

@csnardi csnardi deleted the csnardi:counter-serialization branch Mar 7, 2018

emilio added a commit to emilio/servo that referenced this pull request Mar 7, 2018

@emilio

This comment has been minimized.

Copy link
Contributor

emilio commented Mar 7, 2018

servo/servo#20224 is the Firefox / Servo fix.

emilio added a commit to emilio/servo that referenced this pull request Mar 7, 2018

emilio added a commit to emilio/servo that referenced this pull request Mar 7, 2018

bors-servo added a commit to servo/servo that referenced this pull request Mar 7, 2018

Auto merge of #20224 - emilio:counter-serialization, r=nox
Fix counter() and counters() serialization.

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20224)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request Mar 8, 2018

Auto merge of #20224 - emilio:counter-serialization, r=nox
Fix counter() and counters() serialization.

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20224)
<!-- Reviewable:end -->

emilio added a commit to emilio/servo that referenced this pull request Mar 14, 2018

bors-servo added a commit to servo/servo that referenced this pull request Mar 14, 2018

Auto merge of #20224 - emilio:counter-serialization, r=nox
Fix counter() and counters() serialization.

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20224)
<!-- Reviewable:end -->

emilio added a commit to emilio/servo that referenced this pull request Mar 14, 2018

bors-servo added a commit to servo/servo that referenced this pull request Mar 14, 2018

Auto merge of #20224 - emilio:counter-serialization, r=nox
Fix counter() and counters() serialization.

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20224)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request Mar 14, 2018

Auto merge of #20224 - emilio:counter-serialization, r=nox
Fix counter() and counters() serialization.

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20224)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 15, 2018

servo: Merge #20224 - Fix counter() and counters() serialization (fro…
…m emilio:counter-serialization); r=nox

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7b326529db64ac27f0b956880b3b63dd12cd0c1a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f14cab2e020a7dfcb494721a5f04426cc54637a3

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 15, 2018

No bug - update WPT expectations for servo/servo#20224. r=me
This is a test change that hasn't been synced yet:

  web-platform-tests/wpt#9862

Once it is it'll start passing.

MozReview-Commit-ID: H0RZlep7oX3

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Mar 15, 2018

servo: Merge #20224 - Fix counter() and counters() serialization (fro…
…m emilio:counter-serialization); r=nox

See w3c/csswg-drafts#670 and web-platform-tests/wpt#9862.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7b326529db64ac27f0b956880b3b63dd12cd0c1a

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Mar 15, 2018

No bug - update WPT expectations for servo/servo#20224. r=me
This is a test change that hasn't been synced yet:

  web-platform-tests/wpt#9862

Once it is it'll start passing.

MozReview-Commit-ID: H0RZlep7oX3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.