Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move import of mozinstall/mozdownload #9863

Merged

Conversation

Projects
None yet
5 participants
@csnardi
Copy link
Member

csnardi commented Mar 6, 2018

This caused Travis to error out on all platforms.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 6, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 6, 2018

Move import of mozinstall/mozdownload
This caused Travis to error out on all platforms.

@csnardi csnardi force-pushed the csnardi:install-mozinstall branch from 3e02be9 to 30f26d1 Mar 6, 2018

@csnardi csnardi changed the title Move mozinstall/mozdownload to main requirements.txt Move import of mozinstall/mozdownload Mar 6, 2018

@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Mar 6, 2018

Well, this still breaks installing Firefox; everything else is fixed though.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-06 01:59:36
Finished: 2018-03-06 02:13:43

View more information about this build on:

Add install_requirements method to BrowserSetup
That way, the requirements can be installed prior to browser install.
@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Mar 6, 2018

Should be all working now.

@sideshowbarker sideshowbarker merged commit c031760 into web-platform-tests:master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csnardi csnardi deleted the csnardi:install-mozinstall branch Mar 6, 2018

@@ -1,6 +1,6 @@
{
"run": {"path": "run.py", "script": "run", "parser": "create_parser", "help": "Run tests in a browser",
"virtualenv": true, "install": ["requests", "mozinstall", "mozdownload"], "requirements": ["../wptrunner/requirements.txt"]},

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 6, 2018

Contributor

@csnardi removing the install here means ./wpt install firefox browser fails because they aren't installed?

This comment has been minimized.

Copy link
@csnardi

csnardi Mar 6, 2018

Author Member

After the second commit, I don't believe so. I didn't test it locally but Travis failed to install Firefox with only the first commit and then was fine after the second. Although it could be.

This comment has been minimized.

Copy link
@csnardi

csnardi Mar 6, 2018

Author Member

Actually, you're probably right; it still would have failed though prior to this commit I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.