Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Fix crash when parsing an empty string. #9868

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 6, 2018

When we parse a custom property with an empty string, we hit a DCHECK
that asserts that there's at least one token.

We now throw a TypeError when given an empty string, since a custom
property only matches one or more tokens [1].

[1] https://drafts.csswg.org/css-syntax-3/#typedef-declaration-value

Bug: 819098
Change-Id: I2d5ef71fb36011d0e2efc5e1c3664cb3c8a69f6b
Reviewed-on: https://chromium-review.googlesource.com/950624
Reviewed-by: Rune Lillesveen futhark@chromium.org
Commit-Queue: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#541172}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-06 19:47:53
Finished: 2018-03-06 19:54:34

Failing Jobs

  • MicrosoftEdge:16.16299

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-950624 branch from 44b4822 to 61ad099 Mar 6, 2018

[css-typed-om] Fix crash when parsing an empty string.
When we parse a custom property with an empty string, we hit a DCHECK
that asserts that there's at least one token.

We now throw a TypeError when given an empty string, since a custom
property only matches one or more tokens [1].

[1] https://drafts.csswg.org/css-syntax-3/#typedef-declaration-value

Bug: 819098
Change-Id: I2d5ef71fb36011d0e2efc5e1c3664cb3c8a69f6b
Reviewed-on: https://chromium-review.googlesource.com/950624
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541172}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-950624 branch from 61ad099 to 2a2081a Mar 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f69acf7 into master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-950624 branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.