Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for customElements.upgrade() #9869

Merged
merged 2 commits into from Mar 7, 2018

Conversation

@domenic
Copy link
Member

domenic commented Mar 6, 2018

Follows whatwg/html#3535.

Ideas for more tests welcome, although testing against no implementations is a bit rough.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 6, 2018

Build PASSED

Started: 2018-03-07 03:09:27
Finished: 2018-03-07 03:13:01

View more information about this build on:

@tkent-google
Copy link
Contributor

tkent-google left a comment

lgtm

@tkent-google tkent-google merged commit e3b6514 into master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkent-google tkent-google deleted the ce-upgrade branch Mar 7, 2018

@snuggs snuggs referenced this pull request Mar 15, 2018

Merged

HTTP Resource Representation Variants #164

29 of 29 tasks complete
@bicknellr

This comment has been minimized.

Copy link

bicknellr commented Apr 2, 2018

Hi, I think the last test here about upgrading elements inside a template's content might not be correct: webcomponents/custom-elements#150 (comment) . The owner document of the elements inside the template content doesn't have a browsing context, so I don't think they should be upgraded by customElements.upgrade(template.content). Is that true or is there something else I haven't taken into consideration?

@domenic

This comment has been minimized.

Copy link
Member Author

domenic commented Apr 2, 2018

I don't see anything in the spec about browsing contexts...

@domenic

This comment has been minimized.

Copy link
Member Author

domenic commented Apr 2, 2018

Oh, I didn't click through to your explanation. Sorry, re-parsing... you're probably right...

Edit: confirmed. I will fix the test. Thank you!

@bicknellr

This comment has been minimized.

Copy link

bicknellr commented Apr 2, 2018

Ok, thanks for confirming!

domenic added a commit that referenced this pull request Apr 2, 2018

tkent-google added a commit that referenced this pull request Apr 3, 2018

Fix customElements.upgrade() tests for <template> (#10272)
* Fix customElements.upgrade() tests for <template>

See #9869 (comment).

* Actually fix things

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 15, 2018

Bug 1450754 [wpt PR 10272] - Fix customElements.upgrade() tests for <…
…template>, a=testonly

Automatic update from web-platform-testsFix customElements.upgrade() tests for <template> (#10272)

* Fix customElements.upgrade() tests for <template>

See web-platform-tests/wpt#9869 (comment).

* Actually fix things

wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb
wpt-pr: 10272
wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb
wpt-pr: 10272

mykmelez pushed a commit to mozilla/gecko that referenced this pull request Apr 16, 2018

Bug 1450754 [wpt PR 10272] - Fix customElements.upgrade() tests for <…
…template>, a=testonly

Automatic update from web-platform-testsFix customElements.upgrade() tests for <template> (#10272)

* Fix customElements.upgrade() tests for <template>

See web-platform-tests/wpt#9869 (comment).

* Actually fix things

wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb
wpt-pr: 10272
wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb
wpt-pr: 10272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.